Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image size and image view aspect ratio #86

Open
kswang1029 opened this issue Mar 20, 2023 · 1 comment
Open

image size and image view aspect ratio #86

kswang1029 opened this issue Mar 20, 2023 · 1 comment
Labels
question Further information is requested

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Mar 20, 2023

When we use Session.set_view_area() to configure a view area in a headless mode, it refers to the image size from session.save_rendered_view('test.png') (ie the red box in the attached figure). In practice, we better consider the view_area as the "field of view" of the image viewer (ie the green box in the attached figure). In this case, it provides users the control of the aspect ratio of the "image" in interest directly. Then users may use other tools to compose a grid of images for presentation purposes.

Is it possible to support this? This may need the support from carta-frontend? @veggiesaurus @YuHsuan-Hwang

Screen Shot 2023-03-20 at 14 31 14

@kswang1029 kswang1029 added the question Further information is requested label Mar 20, 2023
@YuHsuan-Hwang
Copy link
Collaborator

@kswang1029 Yes, I think frontend now supports it. We can get the paddings from OverlayStore.paddingLeft/Right/Top/Bottom, and then call set_view_area with green box size + paddings. But we will need to resize it when overlay settings are changed (i.e. paddings changed). Also note that set_view_area includes multiple images.

@kswang1029 kswang1029 added this to the v4.0-stable milestone May 11, 2023
@Kechil Kechil added this to CARTA Sep 18, 2023
@Kechil Kechil moved this to In progress in CARTA Sep 18, 2023
@kswang1029 kswang1029 modified the milestones: v4.0-stable, v5.0-beta Oct 3, 2023
@kswang1029 kswang1029 removed this from CARTA Dec 6, 2023
@kswang1029 kswang1029 added this to CARTA Dec 6, 2023
@kswang1029 kswang1029 moved this to Icebox in CARTA Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
No open projects
Status: Icebox
Development

No branches or pull requests

2 participants