-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icchen/81 high resolution export #113
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image ratio parameter should be added to all three functions for retrieving data -- rendered_view_url
, rendered_view_data
as well as save_rendered_view
. The user could access any of these stages directly. setImageRatio
, resetImageRatio
and setIsExportingImage
should be called from the innermost function (rendered_view_url
).
@confluence I made some modifications according to your suggestions, the issue mentioned above (lock to 100% resolution issue after 20 - 30 mins) is still appearing. I firstly thought it probably due to: we reset the |
@confluence, another issue is that we need to restrict the |
@confluence
This draft PR is to resolve #81.
An argument
image_ratio
and several steps are added intosave_rendered_view
to output png-image with different image ratio:Setting
setIsExportingImage
toTrue
enables setting output image ratio by callingsetImageRatio
. After writing the data to the file, we setsetIsExportingImage
toFalse
and reset the image ratio to1
withresetImageRatio
.The new-configured function does work for a new opened session. With the script like:
I am able to generate a reolution = 400% png image like:
Nevertheless, there's something really odd: after a period of time (say 20 - 30 mins) without touching anything, the exact same execution will then generate something like:
The image is still with the same 400% resolution in size, but the output content seems to lock to 100% resolution.
I still have no idea what's the reason that causes the phenomena, but I will discuss with @YuHsuan-Hwang and see if there's any mechanism at frontend will causes that.