Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icchen/78 colorbar customization #122

Closed
wants to merge 10 commits into from
Closed

Conversation

I-Chenn
Copy link
Contributor

@I-Chenn I-Chenn commented Jun 21, 2023

This PR is to resolve #78.
A function called set_colorbar is added to customize the configuration of colorbar. All the parameters are optional by setting them to None. The logic of enabling configuring the parameters are similar to the frontend GUI. Take border related parameters for example, all the parameters (including border_width, border_cuntom_color and border_color) can be configured only if border_visible is enabled.
There is still a todo for this function, that is to create an Enum for font names in constants.py. Except for that, this funcntion is mostly functional for configuring colorbar. Please let me know if you have any idea about it.

@I-Chenn I-Chenn requested review from confluence and acdo2002 June 21, 2023 16:02
@I-Chenn
Copy link
Contributor Author

I-Chenn commented Jun 26, 2023

@confluence, @acdo2002:
f583c48 added a enum called Font in constants.py to validate the font and provide the font numbers to the front-end.

@confluence
Copy link
Collaborator

I am currently refactoring the WCS overlay code in #123, and this includes adding access to all of the settings on all of the components. I have incorporated some of the enums from this PR into that PR (to be committed soon), and am closing this.

@confluence confluence closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support colorbar customization
2 participants