-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yuhsuan/scroll shadow #2447
Open
YuHsuan-Hwang
wants to merge
35
commits into
dev
Choose a base branch
from
yuhsuan/scroll_shadow
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yuhsuan/scroll shadow #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveluthien
added
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
awaiting code changes
For pull requests that require code changes
and removed
awaiting code review
For pull requests that require code review
labels
Dec 12, 2024
YuHsuan-Hwang
added
awaiting code review
For pull requests that require code review
and removed
awaiting code changes
For pull requests that require code changes
labels
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented features:
Note that we might also consider disabling the shadows when the scroll bar exists, and I prefer we create a separate issue for it if necessary.
Code changes:
App.scss
.$pt-dark-app-background-color
inApp.scss
.ScrollShadow
which applies scroll shadows with a pure CSS approach. There are some disadvantages with the simple approach but most of them look minor:Tested that:
There are some failed e2e tests, to be investigated.
Checklist
For linked issues (if there are):
For the pull request:
no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
protobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendService
changed)BackendService
unchanged)user manual prepared (for large new features)