Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Inconsistent dark theme background #2446

Open
YuHsuan-Hwang opened this issue Dec 10, 2024 · 0 comments · May be fixed by #2447
Open

[Regression] Inconsistent dark theme background #2446

YuHsuan-Hwang opened this issue Dec 10, 2024 · 0 comments · May be fixed by #2447
Assignees
Labels
bug Something isn't working

Comments

@YuHsuan-Hwang
Copy link
Collaborator

Describe the bug

There are some changes to the dark theme background in this dev cycle (possibly results from upgrading to bp v5):

  1. The menu buttons have a darker color comparing to the overall background.
    image

    cf. v4.1: Consistent background.
    image

  2. Among all the widgets, z profile, histogram, and spectral line query widgets has a lighter color comparing to other widgets.

    image

    cf. v4.1: All widgets have the same color.

  3. Undocked widgets have a lighter color comparing to docked widgets. This includes all undocked normal widgets, all settings widgets that cannot be docked, and PV previewer and catalog scatter/histogram plots. (Dialogs have the same color with the docked widgets.)

    image

    When we export png file of the profile, we always get the light background (undocked widget background) instead of the dark one (docked widget background).

    cf. v4.1: Docked widgets, undocked widgets, and dialogs all have the same color.

Expected behavior
Consistent background color.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS 14
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 129
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev
@YuHsuan-Hwang YuHsuan-Hwang added the bug Something isn't working label Dec 10, 2024
@YuHsuan-Hwang YuHsuan-Hwang self-assigned this Dec 10, 2024
@YuHsuan-Hwang YuHsuan-Hwang linked a pull request Dec 10, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant