KSW/support up to 16 profiles in multiprofile plotting mode #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswang1029
changed the title
|
Thanks for spotting the typo! I found that when plotting multiple regions, the first three colors are skipped and the last two colors black and white are not set successfully.
|
The missing color box issue is fixed by removing the "white" and "black" colors from the |
kswang1029
added
awaiting code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #2440.
This PR changes the up-to-10 profiles in the spectral multi-profile plotting mode to up-to-16 based on the available colors from blueprintjs.
Checklist
For linked issues (if there are):
For the pull request:
no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
corresponding fix added/new e2e test createdprotobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendServicechanged)BackendServiceunchanged)user manual prepared (for large new features)