Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps to controller logs #156

Open
confluence opened this issue Aug 24, 2023 · 4 comments
Open

Add timestamps to controller logs #156

confluence opened this issue Aug 24, 2023 · 4 comments

Comments

@confluence
Copy link
Collaborator

It's currently difficult to decipher when logged events happened -- the names of the backend logs provide the only frame of reference.

@daikema
Copy link
Contributor

daikema commented Aug 29, 2023

I think that this is largely due to direct use of console.log for logging purposes.

This could be resolved by including something like log-timestamp or console-stamp, though each would, I think, require a one-line change to basically all our Typescript files.

Or we could move to a different logging framework like, e.g., tslog though I think that'd require few more changes I'd guess.

(Assume we need some input from, e.g., at least @veggiesaurus as to what we should be doing here).

@veggiesaurus
Copy link
Collaborator

If we're using PM2 we can just add timestamps to the log there. Would that be sufficient?

@veggiesaurus
Copy link
Collaborator

If not, I'd suggest we move to tslog, it's pretty great

@daikema
Copy link
Contributor

daikema commented Sep 12, 2023

So for now we seem to have adopted running pm2 with --log-date-format 'DD-MM HH:mm:ss.SSS' as per @veggiesaurus's suggestion, so think this one is likely gonna be getting backburnered. Should we be updated the docs with a mention of this timestamping approach?

@kswang1029 kswang1029 added this to CARTA Dec 6, 2023
@kswang1029 kswang1029 moved this to Icebox in CARTA Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Icebox
Development

No branches or pull requests

3 participants