Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230306 julian #52

Merged
merged 11 commits into from
Mar 6, 2023
Merged

Feature/20230306 julian #52

merged 11 commits into from
Mar 6, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Mar 6, 2023 •
edited
Loading

DEVELOP

  • News detail page
  • See more list

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 1
    • src/lib/common.ts
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

@Julian0701 Julian0701 requested a review from Luphia March 6, 2023 09:04
@Julian0701 Julian0701 self-assigned this Mar 6, 2023
@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
bolt-official ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 10:34AM (UTC)

This was linked to issues Mar 6, 2023
Privacy_policoes Page mobile #44
Open
News Page mobile #45
Open
News Detail Page mobile #46
Open
處理 News API 抓不到的問題 #48
Open
Luphia
Luphia approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 1675d37 into develop Mar 6, 2023
@Luphia Luphia deleted the feature/20230306_julian branch March 6, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Julian0701 @Luphia