Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230302 julian #49

Merged
merged 22 commits into from
Mar 2, 2023
Merged

Feature/20230302 julian #49

merged 22 commits into from
Mar 2, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Mar 2, 2023 •
edited
Loading

DEVELOP

  • Navbar
  • I18n
  • News Page
  • Pagination

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 2
    • moment: 2.29.4
    • react-markdown: 8.0.5
  • new Class / Component: 1
    • src/constants/config.ts
  • new loop:
  • new recursive: 0
  • high risk: 0
  • new sql: 0

@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
bolt-official ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 10:21AM (UTC)

@Luphia Luphia mentioned this pull request Mar 2, 2023
Closed
4 tasks
@Julian0701 Julian0701 requested a review from Luphia March 2, 2023 10:23
@Julian0701 Julian0701 self-assigned this Mar 2, 2023
This was linked to issues Mar 2, 2023
Footer mobile #38
Open
Contact us form mobile #39
Open
About Bolt Page mobile #41
Closed
This was linked to issues Mar 2, 2023
Technology Page mobile #42
Open
FAQ Page mobile #43
Open
Luphia
Luphia approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 15aad90 into develop Mar 2, 2023
@Luphia Luphia deleted the feature/20230302_julian branch March 2, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ Page mobile Technology Page mobile Contact us form mobile Footer mobile About Bolt Page mobile
2 participants
@Julian0701 @Luphia