Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230217 julian #30

Merged
merged 16 commits into from
Feb 19, 2023
Merged

Feature/20230217 julian #30

merged 16 commits into from
Feb 19, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Feb 18, 2023 •
edited
Loading

DEVELOP

  • Technology Items
  • Technology Page
  • FAQ items
  • FAQ Page
  • Privacy_policoes Page

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 3
    • src/components/faq/faqItems.tsx
    • src/components/techology/techologyItems.tsx
    • src/interfaces/news_detail.ts
  • new loop: 2
    • src/pages/faq.tsx line11 ~ line13
    • src/pages/technology.tsx line11 ~ line21
  • new recursive: 0
  • high risk: 0
  • new sql: 0

@Julian0701 Julian0701 requested a review from Luphia February 18, 2023 06:42
@Julian0701 Julian0701 self-assigned this Feb 18, 2023
This was linked to issues Feb 18, 2023
Technology Items #10
Open
Technology Page 完成 #11
Open
FAQ Page 完成 #15
Open
FAQ items #16
Open
Privacy_policoes Page 完成 #14
Open
Luphia
Luphia approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit be95179 into develop Feb 19, 2023
@Luphia Luphia deleted the feature/20230217_julian branch February 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ items FAQ Page 完成 Privacy_policoes Page 完成 Technology Page 完成 Technology Items
2 participants
@Julian0701 @Luphia