Checking whether IntrusiveClient for WaitableAtomic is in use at all except the test.
#994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all except the test.
|
(Of course, if the tests pass, I'll clean up the smoke test to actually run the test, just in a non-intrusive way.) |
|
Okay, seems to work, minor tweaks now ... |
|
@mzhurovich -- good to review per commit! |
|
Agree, I'm all for cleanness and simplicity, and intrusive pointers are pretty niche thing, so I don't think we lose anything by removing this implementation here. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mzhurovich I'm strongly considering removing it, since
Owned<>/Borrowed<>(or the good oldshared_ptr<>) appear to offer a cleaner way than this confusing intrusive thingy.