Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing trunk CI badge for now #302

Closed
wants to merge 2 commits into from
Closed

removing trunk CI badge for now #302

wants to merge 2 commits into from

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Aug 30, 2023

Description

removing trunk CI badge for now since it shows failing but it is actually not failing. Need to figure this out later

Changes

Screenshots

Before

image


After

image

Tests

Known Issues

Notes

trello ticket for this

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

removing `trunk CI` badge for now since it shows failing but it is actually not failing. Need to figure this out later
@trunk-io
Copy link

trunk-io bot commented Aug 30, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug August 31, 2023 00:35
@nh916
Copy link
Contributor Author

nh916 commented Aug 31, 2023

based on prior findings from @InnocentBug this PR would not be very helpful because the badge will point to the default branch (main) and get its status from there. Once there is a new release, then the badge would be fixed.

Closing this PR for now

@nh916 nh916 closed this Aug 31, 2023
@nh916 nh916 deleted the update_README branch September 1, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants