Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right click and drag will "lock" tab item. #132

Open
askmoller opened this issue Nov 24, 2016 · 1 comment · May be fixed by #280
Open

Right click and drag will "lock" tab item. #132

askmoller opened this issue Nov 24, 2016 · 1 comment · May be fixed by #280

Comments

@askmoller
Copy link

To recreate the bug follow these steps:

  1. Right click on a tab that is not selected (and hold the mouse button down).
  2. Move the mouse left or right so it is hovering over the adjacent tab header.
  3. Release the mouse button.

Now the tab that was right clicked on will not respond to left click. So the tab cannot be opened.

The process does not have to be 100% like I have describe. It's just one way that will provoke the behavior.
@BornToBeRoot BornToBeRoot mentioned this issue Nov 16, 2022
Closed
@BornToBeRoot
Copy link

Hi @ButchersBoy,

i found the bug in this method:

Dragablz/Dragablz/DragablzItem.cs

Lines 481 to 498 in e493913

protected override void OnPreviewMouseRightButtonDown(MouseButtonEventArgs e)
{
if (_thumb != null)
{
var currentThumbIsHitTestVisible = _thumb.IsHitTestVisible;
_thumb.SetCurrentValue(IsHitTestVisibleProperty, false);
_rightMouseUpCleanUpDisposable.Disposable = Disposable.Create(() =>
{
_thumb.SetCurrentValue(IsHitTestVisibleProperty, currentThumbIsHitTestVisible);
});
}
else
{
_rightMouseUpCleanUpDisposable.Disposable = Disposable.Empty;
}
base.OnPreviewMouseRightButtonDown(e);
}

The problem is when you hold the right mouse button and the mouse is moved, the IsHitTestVisibleProperty is not set to false again (line 487-489).

My current workaround is:

protected override async void OnPreviewMouseRightButtonDown(MouseButtonEventArgs e)
{            
    if (_thumb != null)
    {                
        var currentThumbIsHitTestVisible = _thumb.IsHitTestVisible;
        _thumb.SetCurrentValue(IsHitTestVisibleProperty, false);
                        
        while (Mouse.RightButton == MouseButtonState.Pressed)
        {
            await Task.Delay(25);
        };
                 
        _thumb.SetCurrentValue(IsHitTestVisibleProperty, currentThumbIsHitTestVisible);
    }

    base.OnPreviewMouseRightButtonDown(e);
}

But i use TargetFramework 6.0

@BornToBeRoot BornToBeRoot mentioned this issue Nov 16, 2022
Closed
BornToBeRoot added a commit to BornToBeRoot/Dragablz that referenced this issue Nov 20, 2022
@BornToBeRoot
Fix: ButchersBoy#132
13953fe
@BornToBeRoot BornToBeRoot mentioned this issue Nov 20, 2022
Closed
BornToBeRoot added a commit to BornToBeRoot/Dragablz that referenced this issue Nov 20, 2022
@BornToBeRoot
Merge pull request #1 from BornToBeRoot/fix/132
674cc97 
Fix: ButchersBoy#132
@BornToBeRoot BornToBeRoot linked a pull request Apr 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple bug fixes & improvements BornToBeRoot/Dragablz
Fix #132 & Update .NET versions
2 participants
@askmoller @BornToBeRoot