You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Considering a directory ./test with entries aBcD, the command ls test prints entries in alphabetical order regardless of case.
Instead the following code:
use walkdir::WalkDir;fnmain(){for entry inWalkDir::new("test").sort_by_file_name(){println!("{}", entry.unwrap().into_path().display());}}
prints entries in the following order:
test
test\B
test\D
test\a
test\c
The reason is clear and is due to the sort method, however it took me some time to detect this behavior in a larger code where I was relying on actual alphabetical sorting.
Although one can easily implement case-insensitive alphabetical order using the lower level sort_by or sort_by_key methods, the existence of an additional sort_by_file_name_case_insensitive method would better clarify the two actual behaviors, and would probably be of wider use than sort_by_file_name.
I'm fine with this, but only if it doesn't introduce new dependencies. And it should be Unicode aware. So hopefully this can be done with APIs in std, although it may involve allocs. I'm personally fine with that.
Considering a directory
./test
with entriesa
B
c
D
, the commandls test
prints entries in alphabetical order regardless of case.Instead the following code:
prints entries in the following order:
The reason is clear and is due to the
sort
method, however it took me some time to detect this behavior in a larger code where I was relying on actual alphabetical sorting.Although one can easily implement case-insensitive alphabetical order using the lower level
sort_by
orsort_by_key
methods, the existence of an additionalsort_by_file_name_case_insensitive
method would better clarify the two actual behaviors, and would probably be of wider use thansort_by_file_name
.If you agree I can issue a PR.
As an additional note, for performance reasons maybe it would be preferable to use the
sort_unstable
/sort_unstable_by
/sort_unstable_by_key
methods instead of thesort
/sort_by
/sort_by_key
methods.The text was updated successfully, but these errors were encountered: