Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV should be 1.40 #153

Open
lemmih opened this issue Jul 25, 2021 · 1 comment
Open

MSRV should be 1.40 #153

lemmih opened this issue Jul 25, 2021 · 1 comment

Comments

@lemmih
Copy link

lemmih commented Jul 25, 2021

Hi,

Line 109 in src/lib.rs uses cfg(doctest) which didn't stabilize until Rust version 1.40.

@fogti
Copy link

fogti commented Aug 17, 2021

If the MSRV is bumped, the following work-around could be dropped as well:

walkdir/src/dent.rs

Lines 179 to 191 in abf3a15

/// Returns true if and only if this entry points to a directory.
///
/// This works around a bug in Rust's standard library:
/// https://github.com/rust-lang/rust/issues/46484
#[cfg(windows)]
pub(crate) fn is_dir(&self) -> bool {
use std::os::windows::fs::MetadataExt;
use winapi::um::winnt::FILE_ATTRIBUTE_DIRECTORY;
self.metadata.file_attributes() & FILE_ATTRIBUTE_DIRECTORY != 0
}
/// Returns true if and only if this entry points to a directory.
#[cfg(not(windows))]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants