New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a better way to configure RTC of DFP ads #31

Open

IT-Cru opened this issue Apr 2, 2019 · 1 comment

IT-Cru commented Apr 2, 2019

I think the current way of adding RTC vendor key / values to DFP ads is not very useful for all cases.

For example Amazon require following format:

"aps": {"PUB_ID": "xxxx","PARAMS":{"amp":"1"}}

Vendor key:

aps (works)

Vendor values:

PUB_ID: XXX (works)
PARAMS: amp:1 (does NOT work)

Or exists their a way to configure such a RTC vendor?

I also reported an other bug some weeks ago on d.o which needs review: https://www.drupal.org/project/ad_entity/issues/3037401

Contributor

shagel7984 commented Apr 3, 2019

Hi,
in the current solution there is no way to configure such a RTC vendor. RTC is configured like:
https://github.com/ampproject/amphtml/blob/master/extensions/amp-a4a/rtc-documentation.md#design -> Per-Slot RTC Specification at the moment.
If you want, you can provide an array in array solution in a patch und we will review it.

Thanks very much for your bug repprt. https://www.drupal.org/project/ad_entity/issues/3037401
We checked it and merged the patch into the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment