Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow automatic grid downloading with the download= approach? #52

Closed
gully opened this issue May 31, 2022 · 1 comment
Closed

Comments

@gully
Copy link
Member

gully commented May 31, 2022

Currently we allow the downloading of a single PHOENIX model with the download= kwarg. Hypothetically we could extend this into the PHOENIXGrid. The problem is that it would take a long time to download everything if the grid is huge (15G).

This approach does do caching though, so maybe it's OK?

Thoughts?

@Sujay-Shankar
Copy link
Collaborator

download = True has been enabled with PHOENIXGrid objects. The initial grid is indeed large, so the first download of the full grid will be a "let this run for a few hours" scenario, but subsequent grid creations are always subsets of the full grid, meaning they'll always lie in cache. Expansion of the parameter ranges results in the entire grid needing to reload, so it's recommended that this downloading route be used on the full grid so that the cache never has to reload again.
The other part of this is with the filenames and directory structure that a local download has that astropy cache lacks, but that part is encapsulated in #83 . Therefore, we close out this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants