Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible units, less hardcoding #46

Open
gully opened this issue May 24, 2022 · 0 comments
Open

More flexible units, less hardcoding #46

gully opened this issue May 24, 2022 · 0 comments

Comments

@gully
Copy link
Member

gully commented May 24, 2022

We currently assume Angstroms everywhere in gollum. While that is convenient, some communities are used to microns or nanometers, or maybe even wavenumbers. We should allow the spectra to reside in whatever units are input. We'll have to sanitize any locations that have Angstroms hardcoded, that's doable. Wavenumbers are harder to deal with because in some places we may assume spectral axes are sorted in certain ways.

The flux units are also tricky. We should consider allowing either $F_\nu$ or $F_\lambda$ values.

These are all straightforward to implement with the astropy equivalencies protocol, it may just require some boiler plate code whenever we do some operation that may depend on the unit (e.g. plotting, black body normalization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant