Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DangerousMemberUsagesAnalyzer should be available for other types #735

Open
mthjones opened this issue Mar 29, 2021 · 0 comments
Open

DangerousMemberUsagesAnalyzer should be available for other types #735

mthjones opened this issue Mar 29, 2021 · 0 comments

Comments

@mthjones
Copy link
Member

In various places in the LMS codebase, we (ab)use the Obsolete attribute to mark methods as being unsafe for general consumption, leading to inaccurate obsoletion warnings being reported. The dangerous members usage analyzer seems like an appropriate alternative, except that there is no way to mark a type as being dangerous without baking it into the analyzer.

To support this, a new attribute could be added to be able to mark members as dangerous (e.g. [DangerousMember( "foo bar baz" )]). Users of the method would need to either be marked [DangerousMember] themselves or be marked with either the Audited or Unaudited attributes that are already being checked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant