Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass seed groups directly to SybilGroupRank rather than finding seed groups by looking at seed users #1

Open
abramsymons opened this issue Jan 25, 2019 · 1 comment
Assignees

Comments

@abramsymons
Copy link
Collaborator

def get_group_type(group_nodes):

If we have for example 3 seed groups A, B, C and A=(a1, a2, a3) B=(b1, b2, b3) and C=(c1, c2, c3) and then (a1, b1, c1) make a group, my approach set this new group as a seed group. It may be problematic.

There is a subtle attack where members of different seed groups can choose to collude to create new seed groups. It doesn't seem likely, but it's probably better to avoid it.

@abramsymons abramsymons self-assigned this Jan 25, 2019
@adamstallard
Copy link
Member

To sum up the bug, if all members of a group are in seed groups, that group will be a seed group even if it wasn't designated as one.

siftal pushed a commit that referenced this issue Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants