From b955e8c204193e20a96736b1f592baeface85239 Mon Sep 17 00:00:00 2001 From: echo Date: Thu, 30 Nov 2023 09:42:14 -0800 Subject: [PATCH] SDK-1711 fix crash on iOS 12 when using the pre-built xcframework --- BranchSDK.xcodeproj/project.pbxproj | 24 ++++++++++++++++++++++++ ChangeLog.md | 5 +++++ scripts/version.sh | 2 +- 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/BranchSDK.xcodeproj/project.pbxproj b/BranchSDK.xcodeproj/project.pbxproj index 5fcfaf838..796471c83 100644 --- a/BranchSDK.xcodeproj/project.pbxproj +++ b/BranchSDK.xcodeproj/project.pbxproj @@ -1954,6 +1954,10 @@ "@loader_path/Frameworks", ); MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; PROVISIONING_PROFILE_SPECIFIER = ""; @@ -1985,6 +1989,10 @@ "@loader_path/Frameworks", ); MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; PROVISIONING_PROFILE_SPECIFIER = ""; @@ -2187,6 +2195,10 @@ ); MACH_O_TYPE = staticlib; MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_MODULE_NAME = BranchSDK; PRODUCT_NAME = BranchSDK; @@ -2222,6 +2234,10 @@ ); MACH_O_TYPE = staticlib; MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_MODULE_NAME = BranchSDK; PRODUCT_NAME = BranchSDK; @@ -2255,6 +2271,10 @@ "@loader_path/Frameworks", ); MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_NAME = BranchSDK; PROVISIONING_PROFILE_SPECIFIER = ""; @@ -2286,6 +2306,10 @@ "@loader_path/Frameworks", ); MARKETING_VERSION = 3.0.1; + OTHER_LDFLAGS = ( + "-weak_framework", + LinkPresentation, + ); PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK; PRODUCT_NAME = BranchSDK; PROVISIONING_PROFILE_SPECIFIER = ""; diff --git a/ChangeLog.md b/ChangeLog.md index 3d960059b..7482a929b 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -24,6 +24,11 @@ v.3.0.0 - pre-iOS 10 locale support - Device carrier. This was used for fraud analysis, but is no longer available on new iOS versions. +v.2.3.1 +This version is for a hotfix on Xamarin, it will not ship as a general iOS release. + +- SDK-2179 Fix LinkPresentation linker issue causing crash on Xamarin when run on iOS 12 or iOS 13. Thanks @LeadAssimilator. + v.2.2.1 Branch iOS SDK 2.2.1 adds parameter for current SKAN 4.0 Window in /v1/open and /v2/event requests. diff --git a/scripts/version.sh b/scripts/version.sh index d8f042c92..f2bd64133 100755 --- a/scripts/version.sh +++ b/scripts/version.sh @@ -107,7 +107,7 @@ if [[ $update ]]; then sed -i '' -e "/^[[:space:]]*s\.version/ {s/\".*\"/\"$version\"/; }" ../BranchSDK.podspec # Update framework version - sed -ie 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj + sed -i '' -e 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj fi