Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow us to specify android-prefix for non-bnc.lt link domains #703

Open
rex-iotum opened this issue Mar 28, 2022 · 0 comments
Open

Allow us to specify android-prefix for non-bnc.lt link domains #703

rex-iotum opened this issue Mar 28, 2022 · 0 comments

Comments

@rex-iotum
Copy link

rex-iotum commented Mar 28, 2022

Currently android-prefix is purely for use with bnc.lt, since its validations severely limit what can be put there. (3-4 char alphanumeric paths only)

I want to be able to specify a custom link-domain while able to specify a custom android-prefix.
Without it there is no way to limit which paths can be deeplinked for Android using this plugin.

IE with this config of
<link-domain value="*.callbridge.com" />
<android-prefix value="/conf/call/" />
to generate the below.
<data android:host="*.callbridge.com" android:pathPrefix="/conf/call/" android:scheme="https"/>
Instead of throwing BRANCH SDK: Invalid "android-prefix" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP

I believe the code already support this, but I am being stopped by this validation !/^[/].[a-zA-Z0-9]{3,4}$/.test(preferences.androidPrefix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant