Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Schedules need a rework #2

Open
BramvdnHeuvel opened this issue Apr 2, 2020 · 0 comments
Open

NPC Schedules need a rework #2

BramvdnHeuvel opened this issue Apr 2, 2020 · 0 comments

Comments

@BramvdnHeuvel
Copy link
Owner

Currently, gen/house/schedule/__init__.py gives people their schedule. However, the file is currently quite a mess, and people have requested for nightly schedules for the guards, so that there will always be a guard awake in the town.

Make sure that you do not pass any objects like House, Person, Neighbourhood or Village into the function, but that you gather all relevant information before you pass them into the function. The reason for this, is that some of the inputs may not have been generated either, and they use a seed of their own as well. If you gather them in the function, they might overwrite the seed that you're using to generate the schedules, and you might generate a different schedule.

Acceptation criteria:

  • There is a chance that an NPC has a nightly schedule;
  • The file gen/house/schedule/__init__.py has been refactored and is now more readable.

Please submit your code in a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant