Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Allow changing og:site_name #8

Open
zubiden opened this issue Mar 16, 2022 · 1 comment · May be fixed by #9
Open

Suggestion: Allow changing og:site_name #8

zubiden opened this issue Mar 16, 2022 · 1 comment · May be fixed by #9

Comments

@zubiden
Copy link

zubiden commented Mar 16, 2022

Some OpenGraph clients display the site name in the link preview (Telegram), making it obvious about origin of that link. The ability to change this property could be a great addition.
Examples (Telegram and Discord):
image
image
Without og:site_name

image
image
With og:site_name
@BramvdnHeuvel BramvdnHeuvel linked a pull request Mar 26, 2022 that will close this issue
Open
@BramvdnHeuvel
Copy link
Owner

Great suggestion! 👍

I did not assume the Rickroll Generator database would receive more columns, so I need to build a bit to automatically update the existing Rickroll database and keep support for existing links.

@BramvdnHeuvel BramvdnHeuvel linked a pull request Mar 26, 2022 that will close this issue
Add fake website name as an optional field #9
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fake website name as an optional field BramvdnHeuvel/Rickroll-Generator
2 participants
@zubiden @BramvdnHeuvel