Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Stimulus concept from base Timeseries #145

Open
stuart-knock opened this issue Jan 31, 2018 · 0 comments
Open

Separate Stimulus concept from base Timeseries #145

stuart-knock opened this issue Jan 31, 2018 · 0 comments

Comments

@stuart-knock
Copy link
Member

Currently, stimuli or driving time-series for a simulation are both derived from Timeseries as a base-class and contained within a Timeseries class... this mixes two concepts, leading to duplicated unused members and generally making the code less clear.

The Timeseries class should serve only the purpose of being the base-class for the various specific time-series classes, eg Sine, PulseRect, PulseSigmoid, White, etc. A second class, called, for example, Stimulus, should be extracted to serve the purpose of combining multiple Timeseries for injection into the simulation, that is it should have Timeseries members but not inherit from Timeseries.

@stuart-knock stuart-knock self-assigned this Jan 31, 2018
@pausz pausz added this to the Mark II milestone Feb 5, 2018
@stuart-knock stuart-knock modified the milestones: Mark II, Backlog, TBD 1 Feb 9, 2018
@stuart-knock stuart-knock removed their assignment Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants