Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handler.destroy() should remove ptr element immediately #120

Open
jarmo opened this issue May 28, 2022 · 0 comments
Open

handler.destroy() should remove ptr element immediately #120

jarmo opened this issue May 28, 2022 · 0 comments

Comments

@jarmo
Copy link

jarmo commented May 28, 2022

Bug report

When calling destroy or destroyAll then ptrElement might become visible for a short period of time when its styleEl is messed up (see #119) due to it not getting removed from DOM immediately.

Current behavior:

When calling handler's destroy function then it does not remove ptrElement. It is being removed by onReset which might be called from multiple codepaths. However, in onReset a timeout is being used which in turn might cause a situation where ptrElement is removed from DOM after its handler's destroy has been called many cycles ago (default removal timeout is 500ms for example).

Expected behavior:

ptrElement should be removed immediately when _handler.destroy is been executed to avoid possible problems where handler has been destroyed and its element will be removed later by co-incidence by some timer.

JSFiddle URL for demo with bug:

N/A

Browsers affected:

Every browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant