Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keywords such as 5k 1% doesn't work #471

Open
JLA4444 opened this issue May 7, 2024 · 4 comments
Open

keywords such as 5k 1% doesn't work #471

JLA4444 opened this issue May 7, 2024 · 4 comments
Assignees
Labels
needs investigation We need to dig deeper into this

Comments

@JLA4444
Copy link

JLA4444 commented May 7, 2024

Describe the bug
The % wildcard is causing issues as keywords as 5k 1% doesn't work

To Reproduce
Steps to reproduce the behavior:

  1. Assign component
  2. keywords: 5k 1%
  3. You have to remove 1% for it to work

Expected behavior
I expect it to be able to easily find precision resistors

KiCad Version

@Bouni
Copy link
Owner

Bouni commented Jul 3, 2024

Search terms ar split by space, so we end up with 5k and 1%.
The first is ignored because its less that 3 characters wide, the later also but % needs to be escaped which I belive is nt done at the moment.
I'll look into this tomorrow (or maybe in the evening, we'll see)

@Bouni Bouni added the needs investigation We need to dig deeper into this label Jul 3, 2024
@chmorgan
Copy link
Collaborator

Tried this and seeing the same thing. Fortunately most resistor values are fractional with 3+ characters. There is likely some way we can force a db scan search on shorter tokens at the expense of performance.

@Bouni
Copy link
Owner

Bouni commented Aug 2, 2024

Maybe we add a search button that can trigger a search if the keyword is to short!?

@chmorgan
Copy link
Collaborator

chmorgan commented Aug 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation We need to dig deeper into this
Projects
None yet
Development

No branches or pull requests

3 participants