IRC client attempts to join channels prematurely in Slack

[stanhu]

When BotBot connects to a Slack IRC server, it seems to be too quick to call bot.JoinAll(), which results in the bot not joining most of the channels. I modified irc/irc.go to join after the message of the day (MOTD) is displayed, and this seems to work:

        // After USER / NICK is accepted, join all the channels,
        // assuming we don't need to identify with NickServ
        bot.RLock()
@@ -628,10 +640,16 @@ func (bot *ircBot) act(theLine *line.Line) {
                bot.Lock()
                bot.isAuthenticating = false
                bot.Unlock()
-               bot.JoinAll()
+               //bot.JoinAll()
                return
        }

+    if theLine.Command == "376" {
+       glog.Infoln("MOTD done, joining now!")
+       bot.JoinAll()
+    }
+

A few questions:

1. Could you implement a more robust way of sending a JOIN message at the right time? For example, the client may attempt to send a LIST command and get a response before attempting to join all channels.
2. Should the IRC client periodically check which channels it is in, and then rejoin any of the channels not in its targeted list?