Refactoring across the repo #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [optional chaining](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining) operator can be used to perform null checks before accessing a property, or calling a function.
refactor: convert logical operator to optional chainining
ci: add .deepsource.toml
In contexts such as an `if` statement's test where the result of the expression will already be coerced to a `Boolean`, casting to a `Boolean` via double negation (`!!`) or a `Boolean` call is unnecessary.
refactor: remove unnecessary boolean casts
SpotlightForBugs
commented
Oct 8, 2023
Joshiy13
approved these changes
Oct 9, 2023
Defelo
requested changes
Oct 11, 2023
| @@ -244,7 +244,7 @@ export default defineComponent({ | |||
| } | |||
| } | |||
|
|
|||
| if (!!!date.value) isValid = false; | |||
| if (!date.value) isValid = false; | |||
| if (!!!time.value || time.value == '00:00:00') isValid = false; | |||
Comment on lines
-35
to
+39
| function setExpand(index) { | ||
| for (let i = 0; i < faqs.value.length; i++) { | ||
| // invert expand-state for clicked item, close all others | ||
| faqs.value[i].expand = i == index ? !faqs.value[i].expand : false; | ||
| function setExpand(index, value) { | ||
| if (value) { | ||
| for (let i = 0; i < faqs.value.length; i++) { | ||
| faqs.value[i].expand = i == index; | ||
| } |
There was a problem hiding this comment.
This was fixed in a previous pr, why did you change this back?
| @@ -45,7 +45,7 @@ export default defineComponent({ | |||
| "chip-color-12", | |||
| ]; | |||
|
|
|||
| return !!props.color | |||
| return (props.color) | |||
There was a problem hiding this comment.
- These parentheses are useless.
- I think, you can use the
??operator here.
|
Preview deployed to https://e3a11daa.academy-preview.pages.dev (total size: 11M) |
|
Hi @SpotlightForBugs, are you still working on this? |
|
@Defelo yes, I am |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
used Deepsource AutofixType of change
Refactored two things:
My Bootstrap Academy username: SFB