Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subtree search #296

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Lauritz-Tieste
Copy link
Contributor

@Lauritz-Tieste Lauritz-Tieste commented Oct 28, 2024

Copy link

Preview deployed to https://de64be0f.academy-preview.pages.dev (total size: 14M)

@TheMorpheus407
Copy link
Contributor

For the design of the frontend, I have some suggestions to make it more intuitive to use.
Let's not use a popup box. Rather if clicked on the button "Search", let it transform to a textfield, with just the icon and the content of what the user types. Then, when he types (3 characters or more) let it search for whatever is currently written.
Filter the elements in the skilltree: Display the nodes, that match the searchterm, and if a course is found or a subskill is found, then display its parent.
If searched in a subnode - like "Grundlagen der Programmierung und Datenhaltung", only search for the subskills and courses within this subnode - eg if search for Unreal Engine, nothing appears, if searched for python, then the python node appears. If a course is found, display the node that contains the course.

@Lauritz-Tieste
Copy link
Contributor Author

I think a search field, as seen here, is not a good idea. There are already so many elements displayed on the skill tree (at least on mobile) that cover up the actual content.

image

@TheMorpheus407
Copy link
Contributor

You're right. However, I think it takes even less space than the current solution.
But maybe we should rethink this. Maybe having a search for the entire platform would make more sense in the long run.
We could integrate it in the top navigation, so the whole page gets searchable. We'll start with skill tree anyways, but later on we can add more to it.
As for the search, it could float to the right, next to the hearts?
And it's just the icon with 3 dots. When you click on it, it expands.
What do you think?

@Lauritz-Tieste Lauritz-Tieste marked this pull request as draft November 2, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter / Suche im Skilltree
2 participants