Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] frontend refactor #32

Open
wants to merge 3 commits into
base: frontend
Choose a base branch
from
Open

[WIP] frontend refactor #32

wants to merge 3 commits into from

Conversation

duskmoon314
Copy link
Collaborator

@duskmoon314 duskmoon314 commented Dec 3, 2021 •
edited by h-guo18
Loading

Notice: Work in Progress!

Please don't merge until this is prepared! Plenty of force pushes is planned.

This PR is to use vercel to preview

Changelog

Utils

  • add eslint:recommended rules

  • add plugin:@typescript-eslint/recommended rules

  • add useWindowDimensions hook

    • TODO change to react-responsive

  • add react-countdown-hook to count 60 seconds

Reimpl

  • import antd.css in _app.tsx
  • semi done reimpl Header
  • semi done reimpl RegisterForm

Planning TODO

  • Split environment to .env.*(.local)?
  • Remove config.json
  • Solve all eslint errors
  • Add husky and lint-staged
  • waiting to add to this list

@duskmoon314
refactor: reimpl header
1d8e16b 
- add useWindowDimensions hook
- add eslint:recommended to rules
@vercel
Copy link

vercel bot commented Dec 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bobankh/thuburrow/38KmjXZmXTLzsmF7xDH7zzMNukLD
✅ Preview: Failed

[Deployment for fd830e9 failed]

@BobAnkh BobAnkh added the enhancement New feature or request label Dec 4, 2021
@BobAnkh BobAnkh linked an issue Dec 26, 2021 that may be closed by this pull request
[WIP] refactor frontend #128
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WIP] refactor frontend
2 participants
@duskmoon314 @BobAnkh