Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time to validate data in CI #68

Closed
demeringo opened this issue Nov 23, 2024 · 2 comments · Fixed by #69
Closed

Reduce time to validate data in CI #68

demeringo opened this issue Nov 23, 2024 · 2 comments · Fixed by #69
Assignees
Labels
enhancement New feature or request

Comments

@demeringo
Copy link
Contributor

demeringo commented Nov 23, 2024

Problem

Validating data in CI takes a long time, mainly to setup the validation environment.

Most of the time is spent install frictionless validation tools (https://github.com/frictionlessdata/frictionless-ci) using a dedicated github action which does not leverage a pre-backed container image.

Additionally, the action does not seem to be well maintained (use old version of node).

And last but not least, the output of current validation is not very practical:

  • the result of validation is a json file that is stored as an artefact of the workflow and is difficut to access and read.
  • the link to the dashboard that is expected to display the resuts does not work (See No access to frictionless runs reports #47)

Solution

See if we can use a custom container (build separately) for the validation step.

Ensure the result of the validation appears directly in the logs of the workflow.

Alternatives

Additional context or elements

It may also permit us to use an different tool to validate data like qsv #55

@demeringo demeringo self-assigned this Nov 23, 2024
@demeringo demeringo added the enhancement New feature or request label Nov 24, 2024
@demeringo
Copy link
Contributor Author

I build such feature and docker image here: https://github.com/demeringo/csv-validator-docker-image

@demeringo
Copy link
Contributor Author

An example of output for a failed validation can be viewed on this PR:
https://github.com/demeringo/csv-validator-docker-image/actions/runs/12000137639/job/33448873520?pr=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant