-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare H5Easy for v3
.
#958
Comments
I would be all for moving all third-party overloads to the core! It would increase functionality, and provide a much clearer platform to add future plug-ins if we like. I lost track a bit, what would it involve? Note that one could even consider dropping the |
The immediate problem is that XTensor supports arrays that don't have a compile time constant rank. This simply isn't something HighFive anticipated and slightly annoying to fix. I've been tempted to drop
without the need to open a file, just pass a path, done. Similar for writing, but there it's important to be able to express truncating vs appending to the file. |
I'm happy to let Eigen work slightly differently for Easy, i.e. Vectors are 1D in easy and 2D in core. The system for automatically adding functionality whenever the optional dependency is available can coexist with the new system that requires including a suitable HighFive header. Not sure there's much more I'd like to do for v3. Therefore, I'll close it for now. |
There's some outstanding modernization in H5Easy, see #897 for some discussion. My preferred solution would be to completely move all logic out of H5Easy and have it act as a layer of simplifying API, without adding any functionality. The alternative would be to find some minimal set of modernization that can later be transformed without breakage.
The text was updated successfully, but these errors were encountered: