Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Performance issues with complex models #238

Open
dmorawetz opened this issue Dec 6, 2024 · 1 comment
Open

[Bug] Performance issues with complex models #238

dmorawetz opened this issue Dec 6, 2024 · 1 comment
Labels
Bug Something isn't working Triage Issue needs to be triaged

Comments

@dmorawetz
Copy link

Using the code from #205, we experience serious performance issues, making this package unusable for us.

We have hundreds of fields in our model with lists of more complex models. Because our form is user-configurable, we have effectively a tree of those complex models. We suspect the performance of PropertyPathHelper.ToFluentPropertyPath to be the problem.

We use this package since 2021 and had never issues with the default MemberNameValidatorSelector.

Concerning the original issue from #204, I think there should be a better way to select the validator of the root model, if needed. It should at least be configurable, as for our project, the previous selection strategy worked better.

It seems like a difficult problem, though, considering #235, #76, and #104.

@dmorawetz dmorawetz added Bug Something isn't working Triage Issue needs to be triaged labels Dec 6, 2024
@pwelter34
Copy link
Collaborator

Thanks for input. In the new year I'll take on reworking the whole property resolution issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants