Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TypeORM #5

Open
JonatanSalas opened this issue Jul 1, 2017 · 5 comments
Open

Add support for TypeORM #5

JonatanSalas opened this issue Jul 1, 2017 · 5 comments
Assignees

Comments

@JonatanSalas
Copy link
Member

No description provided.

@JonatanSalas JonatanSalas self-assigned this Jul 1, 2017
JonatanSalas pushed a commit that referenced this issue Jul 1, 2017
JonatanSalas pushed a commit that referenced this issue Jul 1, 2017
@jcloutz
Copy link

jcloutz commented Nov 30, 2017

Do you have a checklist of features that you're looking to get out of typeorm? I've been poking around with this the last few days and I would be willing to help out if I can.

@JonatanSalas
Copy link
Member Author

@jcloutz from another private project that I have developed, I have a set of abstractions that I want to integrate to typescript-hapi-starter. But I want to do it in a separate branch, my idea is to use the cli create-typescript-api to select which kind of project would you mind to start, and have a super simple api. I don't want to add any boilerplate, only simple setup and a set of constraints so every developer that uses it can start easily.

@jcloutz
Copy link

jcloutz commented Dec 4, 2017

@JonatanSalas sorry for the long delay in responding back, I've been out of town. I don't know the details about what you've done, but what would you think about hiding the repositories and behind interfaces and using a dependency injection container? It would make things fairly easy to swap out for testing if need be, but also allow for easy integration of other persistence libraries such as redis, rethink, couchdb etc..

@JonatanSalas
Copy link
Member Author

It would be a really good thing. I didn't use yet dependency injection in TypeScript, but for testing purposes it would be a really nice to have. In this way we can decouple the way how everything works. If you want you can create a PR and I will review and approve it.

Excuse if I don't put my hands in the code, but I'm covered of work now. In a few days I will be free.

@jcloutz
Copy link

jcloutz commented Dec 8, 2017

I'll look into it, I haven't used it in typescript either but it is a good way to keep things decoupled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants