Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Add support for language prop on Android #22

Open
JonatanSalas opened this issue Aug 24, 2020 · 2 comments
Open

[Feature] - Add support for language prop on Android #22

JonatanSalas opened this issue Aug 24, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request platform:android Issues related to Android code priority:high Prioridad alta de la issue

Comments

@JonatanSalas
Copy link
Member

JonatanSalas commented Aug 24, 2020

Motivation

  • Enable users to configure locale from React-Native side
  • Give parity with IOS which is currently supported

Current Limitations

We've to workaround the current way to configure locale for the PX Android library. In the examples they recommend modifying the context from the Application class by initializing an instance of the PXBehaviourConfigurer class.

The problem with that, is that our library is called as a function which receives parameters and starts an Activity. I'll have to review if constantly modifying the context from a runtime function call instead of modifying at startup would imply a perf issue.

@JonatanSalas JonatanSalas added enhancement New feature or request platform:android Issues related to Android code priority:high Prioridad alta de la issue labels Aug 24, 2020
@JonatanSalas JonatanSalas self-assigned this Aug 24, 2020
@JonatanSalas JonatanSalas changed the title [Feature] - Add support for custom language on Android [Feature] - Add support for language prop on Android Aug 24, 2020
@MartinUgarte
Copy link

Hola! Una consulta, aún sigue en desarrollo el tema del idioma? Ya que me gustaría que la pantalla de Mercado Pago esté en español. Saludos!

@JonatanSalas
Copy link
Member Author

@MartinUgarte todavía no pudimos darle al backlog de las cosas que tenemos, vamos a estar viendo de trabajarlo en unas semanas, pero también aceptamos PRs si es algo muy urgente.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform:android Issues related to Android code priority:high Prioridad alta de la issue
Projects
None yet
Development

No branches or pull requests

2 participants