OP-558: Sylius 2 upgrade #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpysiak
reviewed
Oct 10, 2024
Comment on lines
29
to
30
| exclude: | ||
| - sylius: "~1.13.0" |
There was a problem hiding this comment.
Suggested change
| exclude: | |
| - sylius: "~1.13.0" |
Comment on lines
26
to
27
| exclude: | ||
| - sylius: ^1.13 |
There was a problem hiding this comment.
Suggested change
| exclude: | |
| - sylius: ^1.13 |
remove all excludes
| "doctrine/annotations": "^2.0.0" | ||
| "php": "^8.2", | ||
| "doctrine/annotations": "^2.0.0", | ||
| "sylius-labs/polyfill-symfony-security": "^1.1", |
There was a problem hiding this comment.
Suggested change
| "sylius-labs/polyfill-symfony-security": "^1.1", |
| "doctrine/annotations": "^2.0.0", | ||
| "sylius-labs/polyfill-symfony-security": "^1.1", | ||
| "sylius/calendar": "^0.5.0", | ||
| "sylius/grid-bundle": "^1.13.0-ALPHA.3", |
There was a problem hiding this comment.
Suggested change
| "sylius/grid-bundle": "^1.13.0-ALPHA.3", | |
| "sylius/grid-bundle": "^1.13.0", |
| @@ -39,16 +39,16 @@ | |||
| </service> | |||
|
|
|||
| <service id="sylius.form.type.checkout_address" class="Sylius\Bundle\CoreBundle\Form\Type\Checkout\AddressType"> | |||
| <argument type="service" id="sylius.address_comparator" /> | |||
There was a problem hiding this comment.
this service will probably be changed in sylius 2.0.0 to sylius.comparator.address
| <tag | ||
| name="sylius.live_component" | ||
| key="sylius_admin:blacklisting_rule:form" | ||
| template="@BitBagSyliusBlacklistPlugin/BlacklistingRule/Admin/form.html.twig" |
There was a problem hiding this comment.
next alpha will allow setting components templates in hooks rather then in service definitions
| @@ -0,0 +1,53 @@ | |||
| {% form_theme form '@BitBagSyliusBlacklistPlugin/Form/theme.html.twig' %} | |||
There was a problem hiding this comment.
I will suggest to change views directory to templates
| use Twig\Extension\AbstractExtension; | ||
| use Twig\TwigFunction; | ||
|
|
||
| final class AutomaticBlacklistingConfigurationLabelsExtension extends AbstractExtension |
There was a problem hiding this comment.
Suggested change
| final class AutomaticBlacklistingConfigurationLabelsExtension extends AbstractExtension | |
| final readonly class AutomaticBlacklistingConfigurationLabelsExtension extends AbstractExtension |
|
|
||
| access_control: | ||
| - { path: "%sylius.security.admin_regex%/_partial", role: PUBLIC_ACCESS, ips: [127.0.0.1, ::1] } | ||
| - { path: "%sylius.security.admin_regex%/_partial", role: ROLE_NO_ACCESS } |
There was a problem hiding this comment.
please check latest security configuration in sylius. This access_control is out
| "chart.js": "^3.9.1", | ||
| "flag-icons": "^7.2.3", | ||
| "infinite-tree": "^1.18.0", | ||
| "jquery": "^3.6.0", |
There was a problem hiding this comment.
there is no jquery in sylius anymore :)
senghe
reviewed
Oct 17, 2024
| > | ||
| <services> | ||
| <service | ||
| id="bitbag_sylius_blacklist_plugin.twig.component.automatic_blacklisting_configuration.form" |
There was a problem hiding this comment.
Suggested change
| id="bitbag_sylius_blacklist_plugin.twig.component.automatic_blacklisting_configuration.form" | |
| id="bitbag.sylius_blacklist_plugin.twig.component.automatic_blacklisting_configuration.form" |
For all services
Comment on lines
+50
to
+54
| <tag | ||
| name="sylius.live_component" | ||
| key="sylius_admin:fraud_suspicion:form" | ||
| template="@BitBagSyliusBlacklistPlugin/FraudSuspicion/Admin/form.html.twig" | ||
| /> |
There was a problem hiding this comment.
I would use a formatting like below:
Suggested change
| <tag | |
| name="sylius.live_component" | |
| key="sylius_admin:fraud_suspicion:form" | |
| template="@BitBagSyliusBlacklistPlugin/FraudSuspicion/Admin/form.html.twig" | |
| /> | |
| <tag name="sylius.live_component" | |
| key="sylius_admin:fraud_suspicion:form" | |
| template="@BitBagSyliusBlacklistPlugin/FraudSuspicion/Admin/form.html.twig" | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.