Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process notification payloads with undefined items #96

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ebarbeito
Copy link
Contributor

Hello, this change proposal addresses a PHP warning triggered by an undefined array key "notificationItems" when invoking the Process Notifications Action

Main changes

  • Added implementation where notificationItems payload may be undefined, leveraging the existing NotificationItemsEmptyException
  • Ensured that Process Notifications Action properly manages notifications set as expected
  • Hardened the initialization of NotificationRequest objects
Before After
Before the change
After the change

Additionally, a unit test has been added to verify this behavior

@ebarbeito
Copy link
Contributor Author

Hello, good morning. I am wondering if you could already take a look at this PR

I hope you're doing it well, regards!

@ebarbeito
Copy link
Contributor Author

Hello, I hope this message finds you all well

Just a kindly follow-up on this. I understand you may be busy, but I would greatly appreciate it if you could make a first quick review. If there are any concerns or changes needed, I’m more than happy to address them

Looking forward to hearing from you. Please let me know if I can do anything to help move this.

Many thanks

@ebarbeito
Copy link
Contributor Author

Hello,

I hope you're all doing well. I wanted to follow up again on this PR submitted on September 8

It is quite understandable to have other priorities. I’d appreciate a response to confirm if this is ready to be merged or if any further changes are needed

Thank you for your time
Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant