Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container-ontology back as a dependency #95

Open
bbartley opened this issue Jan 21, 2022 · 0 comments
Open

Add container-ontology back as a dependency #95

bbartley opened this issue Jan 21, 2022 · 0 comments

Comments

@bbartley
Copy link
Collaborator

As a result of #94 and to deploy paml as a binary wheel on PyPI, the paml-check and container-ontology dependencies were removed. This caused import errors in demo notebooks and regression tests which were not easy to resolve simply by marking tests as expected failures. Instead, these test scripts were renamed to avoid discovery by pytest .

Once container-ontology is deployed as a wheel, it should be added back to the setup.py script. See Bioprotocols/container-ontology#13

To restore the tests, DISABLED_execution.py and DISABLED_convert.py should be changed back to test_execution and test_convert to re-enable discovery. Also test_range_reduction should be unmarked as an expected failure.

The .github/workflow/ should also be updated to restore tests on the demo notebooks.

@bbartley bbartley mentioned this issue Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant