Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imageIndex/levelIndex to getHasAlpha #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgios-uber
Copy link

No description provided.

@richgel999
Copy link
Contributor

Hi - The change itself looks good, although it's important to note that whether or not a .basis file has alpha is a property of the entire file, not a specific level/index.
If you look at basis_transcoder::get_image_level_info(), you'll see that the alpha_flag comes from the header itself:

image_info.m_alpha_flag = (pHeader->m_flags & cBASISHeaderFlagHasAlphaSlices) != 0;

So I could accept this change, but it wouldn't really add anything. Thoughts?

@richgel999 richgel999 added the enhancement New feature or request label Dec 19, 2021
@richgel999
Copy link
Contributor

I'm leaving this PR up for investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants