Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title bar being removed/updated on pressing back button #375

Open
SmolAlli opened this issue Jun 22, 2024 · 0 comments
Open

Title bar being removed/updated on pressing back button #375

SmolAlli opened this issue Jun 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SmolAlli
Copy link

Describe the bug
The title for the installer will disappear on the taskbar and when hovering over the application.
image
image

To Reproduce
Steps to reproduce the behavior:

  1. Open up the installer
  2. Accept license agreement and go to next page
  3. Press 'back' button
  4. The title will have disappeared.

Solution
I didn't think this was worth making my own PR so I'll just leave the solution here
In the createMainWindow function in index.js you can add this code to prevent the title from being updated whatsoever after window creation. This mitigates the issue.

// Prevents the page title from being updated
window.on('page-title-updated', (e) => {
    e.preventDefault();
});
@SmolAlli SmolAlli added the bug Something isn't working label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant