Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset viewer doesn't match Figma design and clickable navigation area doesn't match visuals #280

Open
Samuel-Therrien-Beslogic opened this issue Nov 8, 2024 · 1 comment

Comments

@Samuel-Therrien-Beslogic
Copy link
Contributor

Samuel-Therrien-Beslogic commented Nov 8, 2024

Currently:
Image

The clickable area (green and purple in the above image) doesn't match the visuals at all.

The close button is not the same

There's also a major difference with the background where currently it's darkened twice (once for the overlay, and once for the inner element, leaving those dark bands on the side)

Design from figma uses a blur, but also doesn't define navigation:
Image

@Samuel-Therrien-Beslogic
Copy link
Contributor Author

Réponse de Yili:

Salut Sam ! Merci pour indiquer la différence. Le carousel est bon, il est plus pratique pour visualiser plusieurs images. Je vais ajouter les deux control button < > dans Figma. Pour le visuel: le close button, le backgroud transparency et le blur effect, restons sur le design Figma svp. Merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant