Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lethal Company #48

Open
1 task done
zatrit opened this issue Nov 27, 2023 · 2 comments
Open
1 task done

Add Lethal Company #48

zatrit opened this issue Nov 27, 2023 · 2 comments

Comments

@zatrit
Copy link

zatrit commented Nov 27, 2023

Game name

Lethal Company

Request type

Adding a new game to the feed

Target frameworks, package dependencies

  • netstandard21
    • UnityEngine.Modules, 2022.3.9
  • net48
    • UnityEngine.Modules, 2022.3.9

Allowed assembly names

AmazingAssets.TerrainToMesh
Assembly-CSharp
Assembly-CSharp-firstpass
ClientNetworkTransform
DissonanceVoip
Facepunch.Steamworks.Win64
Facepunch Transport for Netcode for GameObjects
Newtonsoft.Json
UnityEngine.UI
Unity.*

Contact details

Discord: @zatrit

Additional information

No response

Package ownership agreement

  • I acknowledge and agree to the above rules
@Lordfirespeed
Copy link

I think Mono.Security is also one of the assemblies, but I'm not 100% sure whether that's one that needs to be in the NuGet package.

Also, I believe the target frameworks should be:

- `netstandard21`
  - `Newtonsoft.JSON`, `13.0.0`
  - `UnityEngine.Modules`, `2022.3.9`
- `net48`
  - `Newtonsoft.JSON`, `13.0.0`
  - `UnityEngine.Modules`, `2022.3.9`

Notably, Lethal Company uses Newtonsoft.JSON = 13.0.0
image

@zatrit
Copy link
Author

zatrit commented Nov 30, 2023

There's no version of Newtonsoft.Json 13.0.0 in the official Nuget repository, so I specified it in the assembly names. I also added net48 as the target framework. I didn't include Mono.Security as it was not specified in some of other requests, so it is not a necessary file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants