Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reanimated #59

Open
tiamed opened this issue Apr 19, 2022 · 1 comment
Open

Support reanimated #59

tiamed opened this issue Apr 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tiamed
Copy link

tiamed commented Apr 19, 2022 •
edited
Loading

Is your feature request related to a problem?

This library currently conflicts with react-native-reanimated@2 or [email protected] showing the error tried to synchronously call function from a different thread

Desired solution (feature)

Mark functions like addPointToPath as a worklet or wrap it using runOnJS

Alternatives considered

No response

Anything else?

https://docs.swmansion.com/react-native-gesture-handler/docs/2.3.0/api/gestures/base-gesture-config/#runonjsvalue-boolean
@tiamed tiamed added the enhancement New feature or request label Apr 19, 2022
@simonapostolovski
Copy link

I had the same issue, check here https://stackoverflow.com/a/71691422/13667202

Same has been reported here software-mansion/react-native-reanimated#2710

I added the runOnJS(true) to the Gesture and its not crashing any more.
image

carlleton pushed a commit to carlleton/react-native-draw that referenced this issue Feb 5, 2024
🐞 fix(canvas): fix bug with BenJeau#59 (comment)
4781cb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiamed @simonapostolovski