Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skia as a renderer (creating abstracting package for canvases) #50

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

BenJeau
Copy link
Owner

@BenJeau BenJeau commented Feb 10, 2022

Changes

  • Created @benjeau/react-native-draw-core utilities package for both renderers
  • Moved @benjeau/react-native-draw to @benjeau/react-native-draw-svg
  • Created @benjeau/react-native-draw-skia
  • Renamed packages folder (removed react-native-draw- prefix)
  • Added addPaths() and setPaths() ref functions

Things Left

  • Have READMEs for all packages and create a new one for the root of the repo
  • Document new props
  • Add examples for the new props
  • Add examples for the new Skia renderer
  • Make the Skia renderer properly handle the multiple paths within a single PathType (honestly debating if I should simply remove that feature)
  • Make sure that the grouping of the paths based on its props (color, thickness, opacity, filled, cap, join) is properly done

Related Issues

closes #38
closes #51
kinda closes #20 (there must be a better OR I do the same thing I do in Skia but within the SVG renderer)

Screenshots (optional)

@BenJeau
Copy link
Owner Author

BenJeau commented Feb 24, 2022

Update - What is blocking me on this PR is the example. Since react-native-skia does not support expo at the moment, I've ported the code to a native react-native project, but I am getting some weird compilation errors on Android and iOS related to react-native-skia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant