Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment and overflow issue for Signup and Cancel buttons on the Signup page #672 #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sagarbendale2004
Copy link

What does this PR do?

This PR addresses the issue where the Signup and Cancel buttons on the Signup page were misaligned and overflowing outside the main container. The buttons were not aligned correctly, causing a poor user interface experience. The fix ensures that the buttons are properly aligned within the form container and do not overflow, providing a more polished and responsive layout.

Fixes #672

Screenshot (14)

Changes Made:

  • Modified the CSS to adjust the alignment of the Signup and Cancel buttons.
  • Ensured that the buttons are properly centered horizontally within the main form container.
  • Applied responsive design techniques to ensure the buttons are correctly aligned across various screen sizes.
  • Used flexbox or grid (depending on the original layout) for more consistent alignment.
  • Added padding and margins to ensure the buttons fit well within the container without overflowing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

##Browser Testing:
Open the Signup page in multiple browsers (Chrome, Firefox, Safari, Edge) to ensure cross-browser compatibility.
Verify that the Signup and Cancel buttons are properly aligned and centered within the form.
Ensure the buttons do not overflow the form container at any point.

  • Test A

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for openfrontendmentor ready!

Name Link
🔨 Latest commit 4d8a394
🔍 Latest deploy log https://app.netlify.com/sites/openfrontendmentor/deploys/6729e28545bd490008f7c533
😎 Deploy Preview https://deploy-preview-673--openfrontendmentor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @sagarbendale2004 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @sagarbendale2004 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Signup and Cancel Button Alignment Overflowing the Main Container
1 participant