Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONEncoder is incorrectly merging subsequent comments #600

Open
leandrocp opened this issue Oct 7, 2024 · 0 comments
Open

JSONEncoder is incorrectly merging subsequent comments #600

leandrocp opened this issue Oct 7, 2024 · 0 comments
Labels
area:visual-editor Impacts Page Visual Editor (Visual Page Builder) bug Something isn't working

Comments

@leandrocp
Copy link
Contributor

The following template

~S|<!-- comment 1 --><!-- comment 2 -->|

Is being encoded as:

[%{"attrs" => %{}, "content" => [" comment 1  comment 2 "], "tag" => "html_comment"}]

It should generate two elements instead of merging into a single comment element.
@leandrocp leandrocp added bug Something isn't working help wanted Looking for contributors area:visual-editor Impacts Page Visual Editor (Visual Page Builder) labels Oct 7, 2024
@leandrocp leandrocp removed the help wanted Looking for contributors label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:visual-editor Impacts Page Visual Editor (Visual Page Builder) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leandrocp