Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit CSS compiler lifecycle #392

Closed
leandrocp opened this issue Jan 11, 2024 · 1 comment · Fixed by #399 or #400
Closed

Revisit CSS compiler lifecycle #392

leandrocp opened this issue Jan 11, 2024 · 1 comment · Fixed by #399 or #400
Assignees
@leandrocp
Labels
bug Something isn't working
Milestone
v0.1.0

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Jan 11, 2024 •
edited
Loading

In order to generate all the expected rules from all pages, the CSS compiler does fetch templates from loaded pages but the problem with this approach is that those pages are not loaded during the app boot which generates an empty stylesheet, and the old approach would fetch the template from the database but would miss some rules since page templates can be post-processed (the final template stored in ETS differs from the one stored in the DB). Note that we can't just load all modules eagerly, see #330 for more info.
@leandrocp leandrocp added the bug Something isn't working label Jan 11, 2024
@leandrocp leandrocp self-assigned this Jan 11, 2024
@AZholtkevych AZholtkevych moved this to Todo in Beacon Jan 23, 2024
leandrocp added a commit that referenced this issue Jan 29, 2024
@leandrocp
Fix CSS compiler
3c06e8f 
Execute template post processing lifecycle on app boot

Close #392
@leandrocp leandrocp mentioned this issue Jan 29, 2024
Merged
@leandrocp leandrocp moved this from Todo to In Progress in Beacon Jan 29, 2024
@leandrocp leandrocp added this to the v0.1.0 milestone Jan 29, 2024
leandrocp added a commit that referenced this issue Jan 29, 2024
@leandrocp
Fix CSS compiler (#399)
4abfd5c 
* Fix CSS compiler

Execute template post processing lifecycle on app boot

Close #392

* format

* cleanup
@leandrocp
Copy link
Contributor Author

Reopening due to a performance issue. Working on it.

@leandrocp leandrocp reopened this Jan 30, 2024
@leandrocp leandrocp mentioned this issue Jan 30, 2024
Merged
@AZholtkevych AZholtkevych moved this from In Progress to Done in Beacon Mar 25, 2024
@AZholtkevych AZholtkevych mentioned this issue Apr 21, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrocp leandrocp

Labels
bug Something isn't working
Projects
Beacon
Status: Done
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Fix CSS compiler BeaconCMS/beacon
Load site asyncly BeaconCMS/beacon
1 participant
@leandrocp