You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thank you for your great work.
In trying to check out Beacon, I noticed that #376 seems to have introduced a bug that prevents pages from rendering, at least in the default setup.
Beacon.Loader.PageModuleLoader calls Beacon.Template.render/1 with assigns although it expects a page module. Calling render/2 seems to fix the issue, however I know too little about Beacon to submit a PR right now.
Beacon.Loader.PageModuleLoader:44 %Phoenix.LiveView.Rendered{} = rendered <- Beacon.Template.render(page_module, assigns) do
Hope that helps
The text was updated successfully, but these errors were encountered:
Hey, thank you for your great work.
In trying to check out Beacon, I noticed that #376 seems to have introduced a bug that prevents pages from rendering, at least in the default setup.
Beacon.Loader.PageModuleLoader calls Beacon.Template.render/1 with assigns although it expects a page module. Calling render/2 seems to fix the issue, however I know too little about Beacon to submit a PR right now.
Beacon.Loader.PageModuleLoader:44
%Phoenix.LiveView.Rendered{} = rendered <- Beacon.Template.render(page_module, assigns) do
Hope that helps
The text was updated successfully, but these errors were encountered: