Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: PageModuleLoader calls wrong render function #378

Closed
scrusi opened this issue Nov 26, 2023 · 3 comments
Closed

Bug: PageModuleLoader calls wrong render function #378

scrusi opened this issue Nov 26, 2023 · 3 comments

Comments

@scrusi
Copy link

scrusi commented Nov 26, 2023

Hey, thank you for your great work.
In trying to check out Beacon, I noticed that #376 seems to have introduced a bug that prevents pages from rendering, at least in the default setup.

Beacon.Loader.PageModuleLoader calls Beacon.Template.render/1 with assigns although it expects a page module. Calling render/2 seems to fix the issue, however I know too little about Beacon to submit a PR right now.

Beacon.Loader.PageModuleLoader:44
%Phoenix.LiveView.Rendered{} = rendered <- Beacon.Template.render(page_module, assigns) do

Hope that helps

@lessless
Copy link

Thanks for reporting @scrusi.
I'm bitten by this as well

@krns
Copy link

krns commented Dec 1, 2023

I think I have the same problem. If I refresh the page fast enough, my page content eventually renders.

beacon.mov

@leandrocp
Copy link
Contributor

My bad, a refactor gone wrong. It should be fixed by #380, please give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants