-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not send data when running on user devices #113
Comments
That just moves the issue. And how can you guarantee, that the device is not a "user" device? There are quite a few simple tools, that automatically make use of containers, that are widely in use. This often makes it effectively impossible to distinguish between "user" and "server" devices. |
Detecting if it is a user device is not a good option in my opinion since there is just too big an error margin (I personally use Linux as an OS for example). I do agree that something should be put in place. (Perhabs a popup in chat to OPS that shows until either agreed or denied?) |
Yes, some edge cases like containers might remain, but some simple checks should cover most edge cases. I'm open for suggestions for impovements. |
Another point which a friend pointed out: Right now, BStats will send metrics when ran on localhost servers that are not port forwarded. This would be a case where there is (as I see it) no argument to be made about "intentionally publishing your ip" so that should definitely be a check in BStats in my opinion |
Sending data from user devices without their explicit consent (i.e., opt in) probably violates the GDPR. Therefore the Metrics class should detect if it runs on a user device and not send data in these cases.
See #112 (comment)
The text was updated successfully, but these errors were encountered: